ADIOS2: Don't implicitly open files#1045
Merged
ax3l merged 2 commits intoopenPMD:devfrom Jul 22, 2021
Merged
Conversation
franzpoeschel
force-pushed
the
fix-adios2-no-implicit-file-opening
branch
from
d49f64a to
6b23478
Compare
6 tasks
Member
|
We will review on Wednesday if we want to follow the route in this PR or instead add this functionality to HDF5, too: |
ax3l
force-pushed
the
fix-adios2-no-implicit-file-opening
branch
from
6b23478 to
94975b5
Compare
ax3l
approved these changes
Jul 22, 2021
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thanks a lot!
I added the .bp test to the PR now to compete it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug found here. The ADIOS2 backend will implicitly open a file if it has not been opened yet. Files should only be opened if the frontend explicitly requested it, otherwise that's an error.
(Why should we be so strict? Implicit opening can make unsuspected calls accidentally collective. Better to have a clear error stating that something went wrong rather than a hanging parallel program.)