File-based iteration encoding: Re-parse padding when necessary#1081
Merged
ax3l merged 5 commits intoopenPMD:devfrom Aug 13, 2021
Merged
File-based iteration encoding: Re-parse padding when necessary#1081ax3l merged 5 commits intoopenPMD:devfrom
ax3l merged 5 commits intoopenPMD:devfrom
Conversation
franzpoeschel
force-pushed
the
fix-late-filebased-setting
branch
from
d76a7ba to
3f8de28
Compare
Contributor
Author
|
I don't understand this line in the old implementation of I implemented a prototype of this in commit 9f2c38d, should we go that way? |
franzpoeschel
commented
Aug 9, 2021
| Series o = Series("./new_openpmd_output_%T.json", Access::CREATE); | ||
|
|
||
| o.setOpenPMDextension(42); | ||
| o.setIterationEncoding(IterationEncoding::fileBased); |
Contributor
Author
There was a problem hiding this comment.
Fun fact: This is exactly the kind of wrong usage that #1048 reports. Since this PR adds sanity-checks to catch such behavior, I'm changing this Series to be file-based now.
franzpoeschel
force-pushed
the
fix-late-filebased-setting
branch
from
587183d to
78cd914
Compare
Member
|
Merged #1080, ready for rebase :) |
franzpoeschel
force-pushed
the
fix-late-filebased-setting
branch
from
78cd914 to
e159ea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1048
Until now, the methods
SeriesInterface::setNameandSeriesInterface::setIterationEncodingdo not modify the parsed filename prefix, padding and postfix.Reparse them when necessary and detect wrong specifications.
Meta: We might want to introduce a label middle-end? This is not a user-facing change (except for fixing a bug), so I don't want to add the label Frontend-C++14. It's a change in the implementation of our frontend, i.e. the middle-end.