Two suggestions to fix CommonADIOS1IOHandlerImpl#1101
Merged
ax3l merged 2 commits intoopenPMD:devfrom Sep 15, 2021
Merged
Conversation
franzpoeschel
force-pushed
the
fix-adios1-namespaces
branch
from
df62013 to
dda356b
Compare
With this fix, CommonADIOS1IOHandler.cpp is included outside of a namespace. This makes it possible to properly include things inside CommonADIOS1IOHandler.cpp without creating accidental double namespaces.
IDEs don't understand the macro thing and it keeps annoying me.
franzpoeschel
force-pushed
the
fix-adios1-namespaces
branch
from
dda356b to
c684b14
Compare
ax3l
approved these changes
Sep 15, 2021
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thank you, that looks good!
I like replacing macros with CRT anytime :D
Member
|
Just saw that there is a regression in this PR when building an all-serial ADIOS1 build (via #1167). |
ax3l
added a commit
that referenced
this pull request
Jan 14, 2022
Update the Clang 10 build to Clang 12 in CI: commit 1 & 2. Commit 3: ADIOS1 serial bugfixes: this is a regression of #1101 since around `CommonADIOS1IOHandler.cpp`
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current macro hack we have works, but is annoying: