added BP5 options

[guj]

No description provided.

[franzpoeschel]

I've pushed two small changes to enforce file endings for BP5 as is done for the other ADIOS2 engines as well, and to fix a small typo. Otherwise looks good to me

[guj]

I've pushed two small changes to enforce file endings for BP5 as is done for the other ADIOS2 engines as well, and to fix a small typo. Otherwise looks good to me

Thanks Franz.

[franzpoeschel]

@ax3l What I said yesterday about OPENPMD_BP_BACKEND was wrong: that variable does not decide whether to use BP3, BP4 or BP5, it decides whether to use ADIOS1 or ADIOS2. It has nothing to do with this PR, so I'll keep my approval.

Failing runs are what I mentioned yesterday about our Windows CI currently having some troubles.

[ax3l]

Discussed today: let's document the new JSON BP5 options that we get from the new ADIOS engine also in https://github.com/openPMD/openPMD-api/blob/dev/docs/source/details/backendconfig.rst#adios2

[ax3l]

Added a small inline comment on rst

[guj]

Discussed today: let's document the new JSON BP5 options that we get from the new ADIOS engine also in https://github.com/openPMD/openPMD-api/blob/dev/docs/source/details/backendconfig.rst#adios2

So Franz will update this?

[franzpoeschel]

We never documented the concrete options that can be forwarded to ADIOS2, but I added a link to the ADIOS2 documentation now where they can be looked up @ax3l

[ax3l]

Thank you both! 🎉

[franzpoeschel]

Note for the milestone: BP5 crashes when not using steps. We should enable steps by default in BP5 before putting out 0.14.5. @ax3l

[ax3l]

@franzpoeschel ok, does this need a separate PR?

[franzpoeschel]

@franzpoeschel ok, does this need a separate PR?

I think that we might do it as part of #1215 and just collect BP5-specific adaptations therein

[ax3l]

As discussed: we do not add BP5 options to the 0.14.* release line but in an upcoming 0.15.0 release.