Automatically deactive span based Put API in ADIOS2 when operators are present#1155
Merged
ax3l merged 3 commits intoopenPMD:devfrom Dec 30, 2021
Merged
Conversation
franzpoeschel
force-pushed
the
automatically-deactive-span-based-api
branch
3 times, most recently
from
d2903ed to
2ad0181
Compare
Member
|
Oh, this cannot be backported to the No worries though, we can follow up with |
|
FYI, I'm putting ADIOS2#2981, so an exception is thrown at the back end level. |
ax3l
force-pushed
the
automatically-deactive-span-based-api
branch
from
2ad0181 to
4a80a03
Compare
Member
|
Rebased since #1043 was merged :) |
ax3l
approved these changes
Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. this issue
Tldr: Span-based Put API can help save memory, but is incompatible with compression operators
This PR automatically deactivates the span-based Put API on a per-variable basis if the variable has operators defined.
Alternatively, a JSON option can be used to activate / deactivate it completely.
TODO: