Fix reading of dataset-specific configuration in ADIOS1#1162
Merged
ax3l merged 2 commits intoopenPMD:devfrom Jan 11, 2022
Merged
Fix reading of dataset-specific configuration in ADIOS1#1162ax3l merged 2 commits intoopenPMD:devfrom
ax3l merged 2 commits intoopenPMD:devfrom
Conversation
8 tasks
ax3l
approved these changes
Jan 11, 2022
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thanks, LGTM 👍
Two suggestions for alignment/spaces, but not a big deal when we add clang-format soon.
Comment on lines
+567
to
+568
| std::cerr << "Warning: parts of the JSON configuration for " | ||
| "ADIOS1 dataset '" |
Member
There was a problem hiding this comment.
Suggested change
| std::cerr << "Warning: parts of the JSON configuration for " | |
| "ADIOS1 dataset '" | |
| std::cerr << "Warning: parts of the JSON configuration for " | |
| "ADIOS1 dataset '" |
Comment on lines
+1772
to
+1773
| std::cerr << "Warning: parts of the JSON configuration for ADIOS1 " | ||
| "remain unused:\n" |
Member
There was a problem hiding this comment.
Suggested change
| std::cerr << "Warning: parts of the JSON configuration for ADIOS1 " | |
| "remain unused:\n" | |
| std::cerr << "Warning: parts of the JSON configuration for ADIOS1 " | |
| "remain unused:\n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1043, I forgot one layer in the JSON schema inside
createDataset. This fixes that and adds a small test.