added support in 8a to use encodings#1231
Merged
franzpoeschel merged 9 commits intoopenPMD:devfrom Apr 1, 2022
Merged
Conversation
ax3l
reviewed
Mar 21, 2022
ax3l
approved these changes
Mar 21, 2022
Contributor
franzpoeschel
left a comment
franzpoeschel
left a comment
There was a problem hiding this comment.
Note that the JSON schema on the dev branch now also has options to pick the encoding:
{"iteration_encoding": "variable_based"}https://openpmd-api.readthedocs.io/en/latest/details/backendconfig.html#backend-independent-json-configuration
So this might not be strictly necessary. Otherwise, we can go forward with this, I just have two small questions.
(Franz's suggestions)
for more information, see https://pre-commit.ci
ax3l
reviewed
Mar 30, 2022
franzpoeschel
approved these changes
Mar 30, 2022
for more information, see https://pre-commit.ci
franzpoeschel
force-pushed
the
8a_with_encodings_again
branch
from
27939a5 to
5c3400b
Compare
Contributor
|
Pushed the last commit again to give the CI another chance. Will merge once it runs clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.