Merged
Conversation
franzpoeschel
force-pushed
the
update-examples-linear-read
branch
from
ed8fab0 to
5e2ba3a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ReadIterations::ReadIterations(Series series) : m_series(std::move(series)) | ||
| {} | ||
| ReadIterations::ReadIterations( | ||
| Series series, |
Check notice
Code scanning / CodeQL
Large object passed by value
Mainly Series::close, Iteration::close, Series::writeIterations, Series::readIterations, READ_LINEAR
franzpoeschel
force-pushed
the
update-examples-linear-read
branch
from
5e2ba3a to
b9ce527
Compare
Member
|
Thanks a lot! As a follow-up, let's not forget these three:
|
ax3l
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series::closeIteration::closeSeries::readIterationsandSeries::writeIterationsSome storeChunk updates are still to come, but they need #1294 and I will probably just push a further commit to that PR with them.
Also fix two bugs noticed when changing the examples.
TODO: