Skip to content

Some fixes for char signs#1378

Merged
ax3l merged 3 commits intoopenPMD:devfrom
franzpoeschel:fix-signed-char
Mar 7, 2023
Merged

Some fixes for char signs#1378
ax3l merged 3 commits intoopenPMD:devfrom
franzpoeschel:fix-signed-char

Conversation

@franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Feb 23, 2023

  • HDF5 backend did not yet fully support signed char, making tests fail on Summit
  • Numpy bindings assumed that char is signed

Follow-up to #1275

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew! 👍

@ax3l ax3l merged commit 6ba68c8 into openPMD:dev Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants