Skip to content

macOS AppleClang12 Fixes#1395

Merged
ax3l merged 3 commits intoopenPMD:devfrom
ax3l:fix-appleclang-shared
Mar 26, 2023
Merged

macOS AppleClang12 Fixes#1395
ax3l merged 3 commits intoopenPMD:devfrom
ax3l:fix-appleclang-shared

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Mar 26, 2023

CI: macOS-10.15

CI already runs on macOS-12. Adds an older runner.
Needs to update to macOS-11 soon.

Fix: Older libc++ (e.g. AppleClang, LLVM Clang <7)

    In file included from /Users/runner/work/openPMD-api/openPMD-api/src/include/openPMD/RecordComponent.hpp:467:
    /Users/runner/work/openPMD-api/openPMD-api/src/include/openPMD/RecordComponent.tpp:381:20: error: no matching constructor for initialization of 'std::shared_ptr<char []>'
                return std::shared_ptr< T[] >{ new T[ size ] };
                       ^                     ~~~~~~~~~~~~~~~~~

Issue seen with AppleClang 12.0 and not seen with 14.0.
Assume 13 might be affected, too.

@ax3l ax3l added this to the 0.15.1 milestone Mar 26, 2023
CI already runs on macOS-12.
Adds an older runner.
@ax3l ax3l force-pushed the fix-appleclang-shared branch 6 times, most recently from 6789469 to 55471f0 Compare March 26, 2023 05:15
Issue seen with AppleClang 12.0 and not seen with 14.0.
Assume 13 might be affected, too.
@ax3l ax3l force-pushed the fix-appleclang-shared branch from 55471f0 to a1aac53 Compare March 26, 2023 05:42
@ax3l ax3l changed the title CI: macOS AppleClang12 Fixes macOS AppleClang12 Fixes Mar 26, 2023
@ax3l ax3l requested a review from franzpoeschel March 26, 2023 06:35
@ax3l
Copy link
Member Author

ax3l commented Mar 26, 2023

tested here with new CI runner and in #1392 ✔️

@ax3l ax3l merged commit c9b0f70 into openPMD:dev Mar 26, 2023
@ax3l ax3l deleted the fix-appleclang-shared branch March 26, 2023 06:49
@ax3l ax3l mentioned this pull request Mar 26, 2023
3 tasks
@ax3l ax3l added the install label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants