Merged
Conversation
ax3l
force-pushed
the
ci-macos-adios1
branch
6 times, most recently
from
5b7dc27 to
67c880f
Compare
franzpoeschel
force-pushed
the
ci-macos-adios1
branch
2 times, most recently
from
d43df96 to
fc7bff6
Compare
Member
Author
|
triggering CI |
Member
Author
|
The |
Contributor
|
The issue is caused by serial builds with ADIOS1 |
Contributor
|
Ok, for some reason, when building serial openPMD-api with ADIOS1, linking the parallel ADIOS1 stub library against JSON.cpp causes this issue... ?? |
Contributor
|
Aaah.. std::vector<std::string> backendKeys{"adios1", "adios2", "json", "hdf5"};And linking that against both ADIOS1 implementations makes them destroy that twice |
Member
Author
|
Great catch, thank you for your help! |
Ensure symbol exports are properly set.
... but don't rely on catching - Add missing .cpp files to ADIOS1 - Avoid global variables in JSON.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: macOS ADIOS1
Ensure symbol exports are properly set.
Fix
Disable runtime error recovery in ADIOS1, include missing symbols, avoid globals in
JSON.cppoptions.First seen on conda-forge/openpmd-api-feedstock#99