Enable clang-format also for .tpp files by using a regex instead of a predefined filter#1403
Merged
ax3l merged 6 commits intoopenPMD:devfrom Apr 3, 2023
Merged
Conversation
Member
You mean for |
Contributor
Author
|
Ok, I tried deactivating the automatic pre-commit file type recognition and instead using a regex for the same purpose: 'types_or': []
files: .*\.(tpp|hpp|cpp)$Locally, that works, but the bot is not reacting? |
Member
|
It looks like it is working but does not push the change back on the PR 🤔 |
Member
Maybe try to rebase against |
ax3l
force-pushed
the
rename-recordcomponent-tpp
branch
from
08be49b to
49c7a6c
Compare
Member
|
Here we go :) |
franzpoeschel
commented
Mar 31, 2023
franzpoeschel
commented
Mar 31, 2023
franzpoeschel
changed the title
Contributor
Author
|
|
franzpoeschel
force-pushed
the
rename-recordcomponent-tpp
branch
from
5ad0270 to
848027b
Compare
for more information, see https://pre-commit.ci
Member
|
Yes, I removed & squashed them intentionally as they were triggers and the old experiment. |
for more information, see https://pre-commit.ci
eschnett
added a commit
to eschnett/openPMD-api
that referenced
this pull request
May 19, 2023
* dev: (82 commits) Docs: Linking to C++ Projects (openPMD#1445) CI: macOS-11 Update (openPMD#1446) [pre-commit.ci] pre-commit autoupdate (openPMD#1437) Fix deprecated storeChunk APIs in first read/write examples (openPMD#1435) Update .readthedocs.yml (openPMD#1438) Doc: Fix Bib Authors (openPMD#1434) [pre-commit.ci] pre-commit autoupdate (openPMD#1425) More careful documentation of streaming API (openPMD#1430) Fix gcc9 warning (openPMD#1429) Python bindings: Release GIL during IO wait operations (openPMD#1381) RecordComponent: Properly handle uninitialized datasets (openPMD#1316) Remove ADIOS1 - Long Live ADIOS2 (openPMD#1419) Post 0.15.0 Changelog Template (openPMD#1420) GitHub Actions: macOS has 3 Cores (openPMD#1421) `version.hpp`: 0.15.1 (openPMD#1417) [pre-commit.ci] pre-commit autoupdate (openPMD#1416) Release 0.15.1 (openPMD#1414) Doc: More HTML Updates (CSS) (openPMD#1413) Enable clang-format also for .tpp files by using a regex instead of a predefined filter (openPMD#1403) Docs: Update Funding (openPMD#1412) ... # Conflicts: # .github/workflows/linux.yml # CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the precommit bot recognize the file. Easier than trying to figure out how to make it accept
.tpptoo...