Merged
Conversation
Member
|
Thank you! Will test in BLAST-ImpactX/impactx#299 |
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 28, 2023
Testing patch in: openPMD/openPMD-api#1407
ax3l
reviewed
Mar 28, 2023
ax3l
reviewed
Mar 28, 2023
| target_link_libraries(openPMD PUBLIC openPMD.ADIOS1.Parallel) | ||
| else() | ||
| # add stubs to prevent missing symbols in Clang ASAN/UBSAN | ||
| target_sources(openPMD PRIVATE ${IO_ADIOS1_SEQUENTIAL_SOURCE} ${IO_ADIOS1_SOURCE}) |
Member
There was a problem hiding this comment.
I think adding ADIOS1IOHandler.cpp and ParallelADIOS1IOHandler.cpp is probably sufficient, but I guess CMake filters duplicate sources anyways.
ax3l
changed the title
ax3l
force-pushed
the
fix-clang-asan-without-adios1
branch
from
03bafa1 to
8393246
Compare
ax3l
approved these changes
Mar 28, 2023
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Tested and works splendid! Thank you! 🎉
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 28, 2023
Testing patch in: openPMD/openPMD-api#1407
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 29, 2023
`dev` has the patch in: openPMD/openPMD-api#1407
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 29, 2023
`dev` has the patch in: openPMD/openPMD-api#1407
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 30, 2023
`dev` has the patch in: openPMD/openPMD-api#1407 for clang ASAB/UBSAN
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 30, 2023
`dev` has the patch in: openPMD/openPMD-api#1407 for clang ASAB/UBSAN
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Mar 30, 2023
`dev` has the patch in: openPMD/openPMD-api#1407 for clang ASAB/UBSAN
ax3l
added a commit
to BLAST-ImpactX/impactx
that referenced
this pull request
Mar 30, 2023
* CMake: openPMD Options Default: ON * Doxygen: openPMD-api Tagfile * Particle Container: Named Attributes * Examples w/ openPMD * openPMD diagnostics element * User-Facing Docs * Remove: Full ASCII Beam Diags Keep reduced ASCII diags for now. * MAD-X: MONITOR Support * openPMD-api version 0.15.0.post2 `dev` has the patch in: openPMD/openPMD-api#1407 for clang ASAB/UBSAN * CI: Update openPMD - New Binary Names - HDF5 dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADIOS1 stubs are still defined in those files, and some compilers (clang 14 with asan & ubsan active) will fail due to missing symbols this at link time.