HDF5: Handle unknown datatypes in datasets#1469
Merged
ax3l merged 5 commits intoopenPMD:devfrom Aug 8, 2023
Merged
Conversation
Member
|
Thanks for the patch! This seems to fail on 32bit Windows right now @franzpoeschel |
Member
|
Does this need test coverage? :) |
abc5c49 to
2a7fada
Compare
Contributor
Author
|
The Windows tests look like a random failure. EDIT: Yep, after restarting the CI, it runs fine. |
2a7fada to
5171ad9
Compare
Contributor
Author
|
For testing, we'll need openPMD/openPMD-example-datasets#20 |
3195cae to
4c24ef7
Compare
4c24ef7 to
3d5f8c7
Compare
34e6ff3 to
b6b75d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit: Throw
error::ReadErrorinHDF5IOHandlerImpl::openDataset(). Upon encountering an error, the middle-end will know that something has gone wrong that it can then recover from, skipping the dataset.Second commit: Sometimes, datasets use custom datatypes based on a native type. This can be supported by checking the parent datatypes if the actual datatypes is not recognized. See here for an example that uses enums to emulate booleans.