Skip to content

Don't require unitSI when reading a patch record component #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ax3l merged 1 commit into from
Jun 30, 2023
Merged

Don't require unitSI when reading a patch record component #1470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions src/backend/PatchRecordComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,24 +143,26 @@ void PatchRecordComponent::flush(

void PatchRecordComponent::read()
{
Parameter<Operation::READ_ATT> aRead;

aRead.name = "unitSI";
IOHandler()->enqueue(IOTask(this, aRead));
IOHandler()->flush(internal::defaultFlushParams);
if (auto val = Attribute(*aRead.resource).getOptional<double>();
val.has_value())
setUnitSI(val.value());
else
throw error::ReadError(
error::AffectedObject::Attribute,
error::Reason::UnexpectedContent,
{},
"Unexpected Attribute datatype for 'unitSI' (expected double, "
"found " +
datatypeToString(Attribute(*aRead.resource).dtype) + ")");

readAttributes(ReadMode::FullyReread); // this will set dirty() = false

if (containsAttribute("unitSI"))
{
if (auto val = getAttribute("unitSI").getOptional<double>();
val.has_value())
{
setUnitSI(val.value());
}
else
{
throw error::ReadError(
error::AffectedObject::Attribute,
error::Reason::UnexpectedContent,
{},
"Unexpected Attribute datatype for 'unitSI' (expected double, "
"found " +
datatypeToString(getAttribute("unitSI").dtype) + ")");
}
}
}

bool PatchRecordComponent::dirtyRecursive() const
Expand Down