make it possible to manually set chunks when loading dask arrays#1477
Merged
ax3l merged 3 commits intoopenPMD:devfrom Aug 17, 2023
Merged
make it possible to manually set chunks when loading dask arrays#1477ax3l merged 3 commits intoopenPMD:devfrom
ax3l merged 3 commits intoopenPMD:devfrom
Conversation
pordyna
force-pushed
the
topic-daskChunks
branch
from
fb5da8b to
1fe460d
Compare
pordyna
force-pushed
the
topic-daskChunks
branch
from
0c924d9 to
b6f0bcf
Compare
for more information, see https://pre-commit.ci
ax3l
reviewed
Aug 9, 2023
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Cool, great idea!!
I added a few suggestions to finalize the PR :)
Copyright and typos in setting chunks for dask arrays. Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Contributor
Author
|
Thanks @ax3l, I applied your suggestions. |
eschnett
added a commit
to eschnett/openPMD-api
that referenced
this pull request
Sep 5, 2023
* dev: Fix CMake: HDF5 Libs are PUBLIC (openPMD#1520) Fix `chmod` in `download_samples.sh` (openPMD#1518) CI: Old CTest (openPMD#1519) Python: Fix ODR Violation (openPMD#1521) replace extent in weighting and displacement (openPMD#1510) CMake: Warn and Continue on Empty HDF5_VERSION (openPMD#1512) Replace openPMD_Datatypes global with function (openPMD#1509) Streaming examples: Set WAN as default transport (openPMD#1511) TOML Backend (openPMD#1436) make it possible to manually set chunks when loading dask arrays (openPMD#1477) [pre-commit.ci] pre-commit autoupdate (openPMD#1504) Optional debugging output for AbstractIOHandlerImpl::flush() (openPMD#1495) Python: 3.8+ (openPMD#1502) # Conflicts: # .github/workflows/linux.yml # src/binding/python/Series.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to override the default chunking behavior when loading to
daskarrays. ForPIConGPUthe default creates a chunk for each GPU with its local domain. When using static load balancing withgridDistinPIConGPU, this results in very uneven chunks. It looks like, for many operations, it makes sense to chunk along the outermost direction only (reading contiguous domains is faster). With this PR this can be achieved with.to_daks_array(chunks={0 : 'auto', 1: -1, 2: -1})