Add visit-like pattern for RecordComponent#1544
Merged
ax3l merged 5 commits intoopenPMD:devfrom Dec 22, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } // namespace detail | ||
|
|
||
| template <typename Visitor, typename... Args> | ||
| constexpr auto RecordComponent::visit(Args &&...args) |
Check notice
Code scanning / CodeQL
Unused local variable
franzpoeschel
force-pushed
the
recordcomponent-visit
branch
from
4521175 to
30333be
Compare
franzpoeschel
force-pushed
the
recordcomponent-visit
branch
from
30333be to
8469b3d
Compare
Also use them to erase some repetition
Also refactor the switchType functions to use the datatype macros
franzpoeschel
force-pushed
the
recordcomponent-visit
branch
from
f062ee2 to
b540b48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1372
TODO:
This adds:
std::variant<...>aliases for openPMD datatypesRecordComponent::visit(...)call that instantiates the passed Functor Template Object with the current type of theRecordComponentRecordComponent::loadChunkVariant()call that returns astd::variant<...>ofshared_ptrtypes