Fix: Strings with a single char in Python#1585
Merged
franzpoeschel merged 3 commits intoopenPMD:devfrom Jan 17, 2024
Merged
Conversation
Instead of "char in doubt"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1517
Problem: In
pipe/__main__.py,dest.set_attribute(key, attr, attr_type)cannot distinguish strings with size 1 from chars (except for explicit char typessigned charandunsigned char).Before #1517, that call converted chars up to string, now it converts strings down to chars.
Old behavior:
New behavior
Since values such as
axisLabels = ["x", "y", "z"]are very frequent, the old behavior was less intrusive.This PR:
char, but keeps the attempts to cast to explicitsignedorunsigned char)Attribute::getOptional<>()more flexible in such conversions (Currentlyopenpmd-pipecreates unreadable files)