Merged
Conversation
c08d260 to
11279f6
Compare
franzpoeschel
commented
Jun 12, 2024
2 tasks
f099a4e to
2feae75
Compare
2feae75 to
247b01e
Compare
ax3l
approved these changes
Jul 16, 2024
Member
ax3l
left a comment
There was a problem hiding this comment.
This is awesome.
Let us also add a parallel test to cover serial and parallel I/O.
Contributor
Author
Done as part of follow-up #1638 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adios2.engine.mode = "what's the name of the mode that we need here does it even exist yet help"It seems this needs no explicit reading logic, just
io.SetParameters("FlattenSteps=on");on the writer side?Automatically add that option in file-based encodingNot possible without breaking other workflowsIntroduces a new flush target
"new_step"used for creating readable output in file-based iteration encoding while the Iteration is not yet fully defined yet.Close #1629