Merged
Conversation
An attempt at fixing this via updating dependencies...
franzpoeschel
added
third party
1 task
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| typename ValueType = typename detail::iterator_access<Iterator>::result_type, | ||
| typename... Extra> | ||
| iterator make_iterator(Iterator first, Sentinel last, Extra &&...extra) { | ||
| typing::Iterator<ValueType> make_iterator(Iterator first, Sentinel last, Extra &&...extra) { |
Check notice
Code scanning / CodeQL
Unused static variable
| typename KeyType = typename detail::iterator_key_access<Iterator>::result_type, | ||
| typename... Extra> | ||
| iterator make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { | ||
| typing::Iterator<KeyType> make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { |
Check notice
Code scanning / CodeQL
Unused static variable
| typename ValueType = typename detail::iterator_access<Iterator>::result_type, | ||
| typename... Extra> | ||
| iterator make_iterator(Iterator first, Sentinel last, Extra &&...extra) { | ||
| typing::Iterator<ValueType> make_iterator(Iterator first, Sentinel last, Extra &&...extra) { |
Check notice
Code scanning / CodeQL
Unused local variable
| typename KeyType = typename detail::iterator_key_access<Iterator>::result_type, | ||
| typename... Extra> | ||
| iterator make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { | ||
| typing::Iterator<KeyType> make_key_iterator(Iterator first, Sentinel last, Extra &&...extra) { |
Check notice
Code scanning / CodeQL
Unused local variable
Member
|
@franzpoeschel can you do a follow-up PR to update the docs and CMake logic to require pybind11 v2.12.0+? |
Member
|
See it in #1637 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factored out of #1637 since this commit has a different author and should not be squashed.
Pybind v2.12.0 is needed for Numpy 2.0 support.
CI will fail since the subsequent CI upgrades from #1637 are still needed.