You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #1619
This lets users decide to flush only the containing Iteration or everything with Attributable::seriesFlush().
TODO:
Maybe use false as a default even. Would be a breaking change, but I'd argue it's the more intuitive behavior and most usage is probably along that line. They're two different functions now.
It seems to me that for an I/O library that requires collective efforts, e.g. BP5, it is better to use iteration->seriesFlush() instead of series->flush(). So, should the default behavior of series->flush() be flushing everything, and set a flag like "dirtyonly= true" if optimization is desired.
naming is a bit confusing to me. by calling iteration->seriesFlush(flush_entire_series=true), it will flush all other iterations in the underlying series owning this iteration? might as well have something like series->flush(dirtyonly=false)? i.e. I think letting iteration/series flush itself only would be cleaner.
Good points. I agree, we could make it maybe more transparent by introducing iteration->flush() and keeping iteration->seriesFlush() to point to the series flush?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1619
This lets users decide to flush only the containing Iteration or everything with
Attributable::seriesFlush().TODO:
Maybe useThey're two different functions now.falseas a default even. Would be a breaking change, but I'd argue it's the more intuitive behavior and most usage is probably along that line.