Conversation
130e38a to
6e91a44
Compare
nischild
left a comment
There was a problem hiding this comment.
Reducing the configure time by a factor of almost five is significant so an obvious improvement.
Just a small disadvantage. One has to remember to update two lines if the version of a dependency should be updated instead of one.
We are working on a wrapper for FetchContent_Declare to add a few features which should improve usability if the SOURCE_DIR directory is defined. We want to reduce the amount of downloads. If you are interested we could discuss this separately.
Thanks! That sounds very interesting as a follow-up, happy to take a look on what you are working on 👍
I would not wait for this extra update for the |
| "Local path to Catch2 source directory (preferred if set)") | ||
|
|
||
| # tarball fetcher | ||
| set(openPMD_catch_tar "https://github.com/catchorg/Catch2/archive/refs/tags/v2.13.10.tar.gz" |
There was a problem hiding this comment.
Will openPMD_catch_branch, openPMD_catch_repo and openPMD_catch_src be removed?
There was a problem hiding this comment.
We will support both. The order now of precedence is:
- src
- tar, or if
openPMD_catch_taris set to off/false/empty/etc. - git
There was a problem hiding this comment.
Docs added that explain the precedence.
Cloning whole repos can be quite slow and CMake does not support shallow clones yet. We can use release tarballs instead.
6e91a44 to
761f136
Compare
Cloning whole repos can be quite slow and CMake does not support shallow clones yet. We can use release tarballs instead.
Follow-up to #1583
Configure from scratch time:
Todo list: