ADIOS2: Use group tables by default in group encoding#1725
Merged
franzpoeschel merged 1 commit intoopenPMD:release-0.16.2from Mar 4, 2025
Merged
Conversation
franzpoeschel
changed the title
franzpoeschel
force-pushed
the
fix-group-table-by-default
branch
from
14409ab to
e1e2944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not done so far, since group tables have been introduced in #1310 as a replacement for another (now no longer supported) breaking ADIOS2 schema. But group tables are fully backward and forward compatible to the traditional ADIOS2 schema as they only add additional data.
Since they in fact create files that are much easier to parse, this is a change that we should introduce by default, especially since we no longer support
Access::READ_LINEARfor group-based ADIOS2 files if they do not contain a group table. In combination with the serialization troubles that BP5 has with group-based encoding, this might lead to situations where users will have to temporarily downgrade the openPMD-api in order to transform their data to a better encoding, as described more closely here: #1724 (comment)This sets the better-supported alternative as a default.
No need to add this to dev since the dev branch made this change by now alredy.