Merged
Conversation
Enable the read of `long double` attributes on MSVC again.
ax3l
force-pushed
the
fix-msvcReadLongDouble
branch
from
bece519 to
84d0a7e
Compare
When accessing `Attribute`s of `long double` on MSVC, the implementation of it is the same as `double`. It will therefore round-trip as `double` (since we match the first, "smallest" type in-order). But since the implementations are the same, it's perfectly castable (both types implement 64bit float precision).
ax3l
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far this does only enable the read of
long doubleattributes on MSVC again.DemonstratesFix #179.Let's see if we can figure out the reason behind it.UsegetCastto read back along doubleon Windows which is identical to adouble. Since both are unique types, we have to check if they are identical which is exactly whatgetCastdoes, see #337.In the future, we should integrate
getCastintoauxiliary::Variant::get<>().