Skip to content

setAttribute: Explicit C-String Handling#341

Merged
anokfireball merged 1 commit intoopenPMD:devfrom
ax3l:topic-setAttributeCstring
Sep 13, 2018
Merged

setAttribute: Explicit C-String Handling#341
anokfireball merged 1 commit intoopenPMD:devfrom
ax3l:topic-setAttributeCstring

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Sep 13, 2018

Explicitly handle C-strings in order to avoid implicit casts. Makes bindings easier.

Split-off from #333

Explicitly handle C-strings in order to avoid implicit casts.
Makes bindings easier.
@ax3l ax3l force-pushed the topic-setAttributeCstring branch from f79e1fa to 27ed8c9 Compare September 13, 2018 09:05
@anokfireball
Copy link
Member

anokfireball commented Sep 13, 2018

Now here's one I don't understand:

The actual unit test with gcc@7.3.0+MPI succeeds, yet the same config (+Python) in the coverage test throws:

Test can only be run with at least two ranks
terminate called after throwing an instance of 'std::runtime_error'
  what():  A Record can not be written without any contained RecordComponents: position
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ParallelIOTests is a Catch v2.2.1 host application.
Run with -? for options
-------------------------------------------------------------------------------
hdf5_write_test_zero_extent
-------------------------------------------------------------------------------
/home/travis/build/openPMD/openPMD-api/test/ParallelIOTest.cpp:146
...............................................................................
/home/travis/build/openPMD/openPMD-api/test/ParallelIOTest.cpp:146:FAILED:
due to a fatal error condition:
  SIGABRT - Abort (abnormal termination) signal
===============================================================================
test cases:  3 | 2 passed |1 failed
assertions: 13 |12 passed |1 failed

UPDATE
This also happens on dev, so it's not a blocker for this PR.

@anokfireball anokfireball merged commit fad97ed into openPMD:dev Sep 13, 2018
@ax3l ax3l deleted the topic-setAttributeCstring branch September 13, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants