SerialIO ADIOS1 Test: Bool

[ax3l]

ADIOS1 bool testing. Probably needs a fix.

[anokfireball]

values is a void* that is given to ADIOS, allocated here.
To support bool writing (with the workaround), this will have to be allocated as uint8_t.
The Attribute is passed as bool, so that case needs to be handled manually.

void
CommonADIOS1IOHandlerImpl::flush_attribute(int64_t group, std::string const& name, Attribute const& att)
{
    auto dtype = att.dtype;
    if( dtype == Datatype::BOOL )
        dtype = Datatype::UCHAR;

    switch( dtype ) /* NOTE - workaround dtype */
    /* ... */

    auto values = auxiliary::allocatePtr(dtype, nelems); /* NOTE - workaround dtype */
    switch( att.dtype ) /* NOTE - original dtype */
    {
        case DT::BOOL:
        {
            auto ptr = reinterpret_cast< unsigned char* >(values.get());
            *ptr = static_cast< unsigned char >(att.get< bool >());
            break;
        }
    }
    /* ... */
}

[ax3l]

@C0nsultant can you push the change you are suggesting on the PR branch? I am open to any changes here, just needed a demonstrator to show what I saw was causing the crash during write :)

(Was on the plane and road today, sorry for the missing annotations!)

pushed changes

[ax3l]

@C0nsultant thx! :)