Merged
Conversation
ax3l
force-pushed
the
fix-importLibsUsage
branch
3 times, most recently
from
4917ee9 to
c8011d4
Compare
Follow-up to use CMake third party librarys as IMPORTED. Make sure - `PRIVATE` JSON target does not leak into install - variant target is known
ax3l
force-pushed
the
fix-importLibsUsage
branch
from
c8011d4 to
c8c4f92
Compare
Member
Author
|
@franzpoeschel does the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to use CMake third party librarys as IMPORTED.
Make sure
PRIVATEJSON target does not leak into installFollow-up to #389 in order to fix reported issues when used in third-party libs: #389 (comment)