Merged
Conversation
When passing the parameters to the `adios_select_method`, c-pointer of a temporary c++ string was taken which results in a heap-use-after-free. We saw this as sporadic occuring/missing meta-data file. Also, change the default to create a meta-data file unless deactivated in performance tuning. Otherwise, too confusing for users to always run `bpmeta` (and not possible e.g. during our MPI benchmark that does a write-then-read). Found with clang (6.0) and `-fsantize=address` plus exports: ``` export ASAN_OPTIONS=detect_stack_use_after_return=1:detect_leaks=0:check_initialization_order=true:strict_init_order=true:detect_stack_use_after_scope=1 ``` Refs: https://github.com/google/sanitizers/wiki/AddressSanitizer https://github.com/google/sanitizers/wiki/AddressSanitizerExampleUseAfterReturn
ax3l
force-pushed
the
fix-adiosMPIoptHeapUse
branch
from
5c73d0b to
06760a5
Compare
This was referenced Jan 8, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing the parameters to the
adios_select_method, c-pointer of a temporary c++ string was taken which results in a heap-use-after-free.We saw this as sporadic occurring/missing meta-data file, e.g. #37 (comment) .
Also, change the default to create a meta-data file unless deactivated in performance tuning. Otherwise, too confusing for users to always run
bpmeta(and not possible e.g. during our MPI benchmark that does a write-then-read).Found with clang (6.0) and
-fsantize=addressplus exports:Refs:
https://github.com/google/sanitizers/wiki/AddressSanitizer
https://github.com/google/sanitizers/wiki/AddressSanitizerExampleUseAfterReturn