Follow-up – Allow flushing before defining position and positionOffset components of particle species#519
Merged
ax3l merged 1 commit intoopenPMD:devfrom Jun 6, 2019
Conversation
ax3l
reviewed
Jun 6, 2019
src/ParticleSpecies.cpp
Outdated
| { | ||
| iterator it = find("position"); | ||
| if ( it != end() ) | ||
| { |
Member
There was a problem hiding this comment.
you can actually spare the {} for a single following line :)
Contributor
Author
There was a problem hiding this comment.
I need to admit that I don't like that style that much, but since it's part of the 20 commandments, I will comply ;)
This was a bug in the last commit
franzpoeschel
force-pushed
the
fix-position-positionOffset
branch
from
bd6500d to
befeda2
Compare
ax3l
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #518 contains a little bug, the unit dimensions need to be set before flushing.