Merged
Conversation
ax3l
force-pushed
the
topic-pkgconfig
branch
3 times, most recently
from
25a5199 to
7223b02
Compare
ax3l
changed the title
ax3l
commented
Jul 19, 2019
| Additional linker and compiler flags for your project are available via: | ||
| ```bash | ||
| pkg-config --libs openPMD | ||
| # -L${HOME}/somepath/lib -lopenPMD |
Member
Author
There was a problem hiding this comment.
note: the --static output requires proper listing of Libs.private which is non-trivial. Luckily, we changed the default build variant to shared #505 for the next release, so pkg-config installs are only supported with shared builds for now, which is a sane limitation.
Generate .pc files for consumption via pkg-config. This is useful for projects with legacy build environments that do not use a build system generator such as CMake and instead write Makefiles by hand or compile manually.
ax3l
force-pushed
the
topic-pkgconfig
branch
8 times, most recently
from
e0c1f00 to
e61cbd0
Compare
Instead of adding public defines for variants of the openPMD-api library, configure a `openPMD/config.hpp` header that does the same job. These variants cannot be changed after install anyway and avoid complicated exposure via the build system instead of just using our facade headers.
This was referenced Jul 19, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate
.pcfiles for consumption viapkg-config. This is useful for projects with legacy build environments that do not use a build system generator such as CMake and instead writeMakefiles by hand or even compile manually by calling the compiler directly.Example to update downstream: WarpX BLAST-WarpX/warpx#80
Also removes the public defines for "variants" of the installed library from the build system and instead pulls them automatically in the facade headers via a
openPMD/config.hppfile. Since the library "variant" cannot be changed after the fact anyway, this avoids having to set magic defines downstream.