Merged
Conversation
ax3l
force-pushed
the
topic-jsonAlwaysON
branch
from
28fb21c to
23e7426
Compare
Since we ship the dependencies for the private JSON backend with our source code and the dependency is of very hight quality and very portable, we can just compile it by default. This is very similar to previous behavior, in the sense that it was `-DopenPMD_USE_JSON=AUTO` (internal) activated unless explicitly deactivated during compile. Enabling JSON by default and making it a required dependency enables us to use it for further internal tasks, such as runtime option parsing of user parameters for all backends.
ax3l
force-pushed
the
topic-jsonAlwaysON
branch
from
23e7426 to
9fe374b
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we ship the dependencies for the private JSON backend with our source code and the dependency is of very hight quality and very portable, we can just compile it by default.
This is very similar to previous behavior, in the sense that it was
-DopenPMD_USE_JSON=AUTO(internal) activated unless explicitly deactivated during compile.Enabling JSON by default and making it a required dependency enables us to use it for further internal tasks, such as runtime option parsing of user parameters for all backends #569 .