Open
Conversation
ax3l
commented
Oct 1, 2020
| @@ -1,5 +1,8 @@ | |||
| HeaderFilterRegex: '((^(?!\/share\/openPMD\/).*)*include\/openPMD\/.+\.hpp|src\/^(?!binding).+\.cpp$)' | |||
Member
Author
There was a problem hiding this comment.
Hm, do we filter too many files here?
My IDE shows more locations than the examples...
Add a clang-tidy check that makes sure the rule of zero/five is obeyed. https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-special-member-functions.html
ax3l
force-pushed
the
topic-ruleOfFive
branch
from
98ea0f8 to
bfb3a25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a clang-tidy check that makes sure the rule of zero/five is obeyed.
Core Rule guideline C.21
(Note sure if this clang-tidy check also covers C.20... aka "rule of zero")
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-special-member-functions.html