[WIP] Series: Non-Copyable

[ax3l]

Delete the Copy-constructor in Series and add a move-constructor to Series and Attributable. This is a quick-fix for currently inconsistent handle-creation during copy.

Reproducer and long-term strategy as handle: #804

To Do

• tests for move constructor in Attributable and Series
• entry in NEWS
• Python also affected?

[franzpoeschel]

Reason for the segfault:

In this line, pointer s goes not to the move-constructed new Series object copy, but to the old (and now invalid) instance o0. Essentially, the Series class is currently (via some detours) self-referential and even moving it will break things.

The old test only really ever ran fine by accident: Flushing from the copy was ok, since o0 was still around to be used. Now that it's moved from, the test breaks.

So, for a quick fix, I'd suppose that move operations must be disallowed too. For a long-term fix, pointers and references must only go to (internal) classes without copy and move constructors.

Also, I think that Series::~Series would currently fail on a moved-from Series object, likely on a null-pointer dereference of a moved-from Container::m_container.

[ax3l]

Fixed with #886 #936 #955