Merged
Conversation
Prepare the support for `Iteration::open()` for following non-collective, parallel reads for ADIOS1.
72c260a to
80728d0
Compare
Member
Author
|
Thank you, @franzpoeschel! Great catch! I printed around that open but did not notice the double-open :) |
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this pull request
Jan 29, 2021
* Fix ADIOS1: Iteration::open() Prepare the support for `Iteration::open()` for following non-collective, parallel reads for ADIOS1. * Fix ADIOS1 file opening Co-authored-by: Franz Pöschel <franz.poeschel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the support for
Iteration::open()for following non-collective, parallel reads for ADIOS1.Follow-up to #862 fixing ADIOS1 in #856