Merged
Conversation
225c656 to
9714380
Compare
2ff94ad to
dab0b52
Compare
c8e4cab to
8637e32
Compare
ax3l
commented
Apr 6, 2021
Add bindings for all record components to dask arrays (ND mesh record components and 1D particle record components).
8637e32 to
c1121d7
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bindings for all record components to dask arrays (ND mesh record components and 1D particle record components).
Follow-Up To Do
Multi-node / multi-worker setup (aka distributed) and already seen with
compute="processes":and same for data frames:
Similar to
h5py, things might get tricky here: https://stackoverflow.com/questions/63236728/dask-to-hdf5-write-fails-h5py-cannot-be-pickledMaybe we find a way to pickle a
Record_Componentby transporting the info needed to initialize a non-MPI series and re-creating the record component from it: file name, deferred open, iteration, record & record component name.References