Retrieve paths of objects in the openPMD hierarchy#966
Merged
ax3l merged 4 commits intoopenPMD:devfrom Apr 21, 2021
Merged
Conversation
franzpoeschel
force-pushed
the
feature-mypath
branch
from
f76ecd7 to
c5868a3
Compare
ax3l
approved these changes
Apr 21, 2021
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot (and great coverage!)
| internal::SeriesInternal const & retrieveSeries() const; | ||
| internal::SeriesInternal & retrieveSeries(); | ||
|
|
||
| std::vector< std::string > myPath() const; |
Member
There was a problem hiding this comment.
Can you please add a doxygen string for this one? :)
This would be a good place to explain the concept of what's in that vector of strings.
Contributor
Author
There was a problem hiding this comment.
I think there are also some other places where a little comment will help, so yep will do
franzpoeschel
force-pushed
the
feature-mypath
branch
from
de4d722 to
ed1dbca
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for "serialization" in DASK contexts.
TODO: