This repository was archived by the owner on May 5, 2022. It is now read-only.
accounting for the chain function in EsriRestDownloadTask.field_names_to_request #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! Can we get a unit test added for this change? |
Contributor
Author
|
added a test though unclear why no build is running. |
Member
|
Whoa, weird. |
Member
|
I'm unsure why Circle isn't building. I've turned it off an on again, and I'll need to try jiggling it with a new commit to see if it works. |
Member
|
Well this is frustrating. Sorry the tests have somehow stopped — I'll keep digging when I have a free moment, to figure out what’s happening. |
Contributor
Author
|
In any case I've tested the change locally and it looks fine. |
Member
|
Closing in favor of #764. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to test the new
chainfunction, I realized that one other change to machine is required for it all to work. The reason for the failed build in openaddresses/openaddresses#3203 is inEsriRestDownloadTask.field_names_to_request. This method assumes each conform function has a property named either "fields" or "field", which does not apply to the compoundchainfunction.This change collects fields from the chain's constituent functions.