Skip to content

fix: gracefully handle unsupported thread/name/set on older Codex CLI #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkundel-openai merged 2 commits into from
Apr 8, 2026
+10 −1
Merged

fix: gracefully handle unsupported thread/name/set on older Codex CLI #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc597ce
fix: gracefully handle unsupported thread/name/set on older Codex CLI
tmchow Apr 3, 2026
0268700
refactor: only suppress unsupported-method errors for thread/name/set
tmchow Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion plugins/codex/scripts/lib/codex.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,16 @@ async function startThread(client, cwd, options = {}) {
const response = await client.request("thread/start", buildThreadParams(cwd, options));
const threadId = response.thread.id;
if (options.threadName) {
await client.request("thread/name/set", { threadId, name: options.threadName });
try {
await client.request("thread/name/set", { threadId, name: options.threadName });
} catch (err) {
// Only suppress "unknown variant/method" errors from older CLI versions
// that don't support thread/name/set. Rethrow auth, network, or server errors.
const msg = String(err?.message ?? err ?? "");
if (!msg.includes("unknown variant") && !msg.includes("unknown method")) {
throw err;
}
}
}
return response;
}
Expand Down