fix: prevent Windows ENOENT for codex availability checks#162
Closed
Abdooo2235 wants to merge 1 commit intoopenai:mainfrom
Closed
fix: prevent Windows ENOENT for codex availability checks#162Abdooo2235 wants to merge 1 commit intoopenai:mainfrom
Abdooo2235 wants to merge 1 commit intoopenai:mainfrom
Conversation
Collaborator
|
Thanks this should have been fixed in #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Windows command resolution failure where Codex availability checks could fail with
ENOENTeven whencodexwas installed globally and available in PATH.On Windows, command resolution can require shell execution for PATH-resolved shims. This change keeps Windows shell behavior and adds explicit regression coverage for it.
Closes #161.
Changes
shellnow resolves fromoptions.shell ?? platform === "win32"platformandspawnSyncImpltest hooksshell: truefor PATH-resolved commandsValidation
npm test(pass)tests/process.test.mjsfor Windows/non-Windows shell behaviorRisk
Low. Change is scoped to process invocation wiring and covered by targeted and full-suite tests.