fix: add shell:true for binaryAvailable on Windows#19
Closed
masayan-kazu wants to merge 1 commit intoopenai:mainfrom
Closed
fix: add shell:true for binaryAvailable on Windows#19masayan-kazu wants to merge 1 commit intoopenai:mainfrom
masayan-kazu wants to merge 1 commit intoopenai:mainfrom
Conversation
spawnSync cannot resolve .cmd wrappers (npm, codex) without shell:true on Windows, causing /codex:setup to report them as missing. Fixes openai#17
Collaborator
|
Closing as duplicate of #13. Thanks for the contribution |
Author
|
Thanks for the heads-up! I didn't notice #13 before filing. Happy to see it's already being tracked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
npmandcodexare installed as.cmdbatch wrappers.spawnSyncwithoutshell: truecannot resolve.cmdextensions,causing
binaryAvailable()to return ENOENT for both.This makes
/codex:setup(and all commands depending ongetCodexAvailability()) report npm as "Missing" and Codex as"Not installed", even though both are correctly in PATH.
Changes
shelloption throughrunCommandtospawnSyncshell: trueonwin32inbinaryAvailableonlyTesting
Tested on Windows 11 + Claude Code CLI (Git Bash / mingw64):
/codex:setup→ npm Missing, Codex Not installed/codex:setup→ npm Available, Codex AvailableFixes #17