fix: add shell: true on Windows for codex app-server spawn#39
Closed
cadamsgcmlp wants to merge 1 commit intoopenai:mainfrom
Closed
fix: add shell: true on Windows for codex app-server spawn#39cadamsgcmlp wants to merge 1 commit intoopenai:mainfrom
cadamsgcmlp wants to merge 1 commit intoopenai:mainfrom
Conversation
On Windows, npm installs global packages as .cmd batch wrappers. Node.js spawn() without shell: true cannot resolve .cmd files, causing ENOENT when launching the app-server. This matches the existing pattern in process.mjs (line 12) where runCommand and binaryAvailable already set shell on win32. Fixes openai#32 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Thank you! Closing in favor of #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
spawn("codex", ["app-server"], ...)inapp-server.mjsfails withENOENTbecause Node.jsspawnwithoutshell: truecannot resolve the.cmdwrappers thatnpm install -gcreates.This one-line fix adds
shell: process.platform === "win32", matching the existing pattern inprocess.mjsline 12.Fixes #32
Test plan
/codex:setupreports ready before and after the change/codex:review --base <branch>fails withspawn codex ENOENTbefore the fix, completes successfully after