fix: make test paths portable across different environments#45
Closed
zylar06 wants to merge 2 commits intoopenai:mainfrom
Closed
fix: make test paths portable across different environments#45zylar06 wants to merge 2 commits intoopenai:mainfrom
zylar06 wants to merge 2 commits intoopenai:mainfrom
Conversation
Collaborator
|
Thank you for the contribution! Closing in favor of #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed hardcoded absolute paths in test files that were specific to the original developer's local environment.
Changes
/Users/dkundel/code/codex-pluginwith a dynamic path resolution usingfileURLToPath(import.meta.url)Why
The original test files contained absolute paths pointing to a specific developer's machine (
/Users/dkundel/code/codex-plugin). This caused tests to fail when run on any other machine or environment.How
Used
fileURLToPath(import.meta.url)combined withpath.resolve()andpath.dirname()to compute the project root path dynamically relative to the test file's location, making the tests portable across all environments.