fix: add shell option for Windows spawn in app-server#47
Closed
alexhuang0915 wants to merge 1 commit intoopenai:mainfrom
Closed
fix: add shell option for Windows spawn in app-server#47alexhuang0915 wants to merge 1 commit intoopenai:mainfrom
alexhuang0915 wants to merge 1 commit intoopenai:mainfrom
Conversation
On Windows, npm global binaries are installed as `.cmd` wrappers. Node.js `spawn()` without `shell: true` cannot resolve these, causing `ENOENT` when launching `codex app-server`. This matches the pattern already used in `process.mjs` line 11: `shell: process.platform === "win32"` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Thank you! Closing in favor of #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex) are installed as.cmdwrappersspawn("codex", [...])inapp-server.mjswithoutshell: truecausesENOENTbecause Node.js cannot resolve.cmdfiles directlyshell: process.platform === "win32"to match the existing pattern inprocess.mjsline 11Reproduction
claude plugins install codex@openai-codex/codex:rescueor any task that triggersapp-serverstartupspawn codex ENOENTerrorFix
One-line change: add
shell: process.platform === "win32"to thespawn()options inSpawnedCodexAppServerClient.initialize().This is consistent with how
process.mjsalready handles Windows compatibility for all othercodexbinary invocations viarunCommand().Test plan
codex setup --jsonstill reportsready: truecodex-companion.mjs taskcompletes successfully on Windows🤖 Generated with Claude Code