fix: add shell option for Windows .cmd wrapper resolution#5
Closed
51ck0n1n3t33n wants to merge 1 commit intoopenai:mainfrom
Closed
fix: add shell option for Windows .cmd wrapper resolution#551ck0n1n3t33n wants to merge 1 commit intoopenai:mainfrom
51ck0n1n3t33n wants to merge 1 commit intoopenai:mainfrom
Conversation
On Windows, Node.js spawnSync cannot resolve .cmd wrappers (like codex.cmd and npm.cmd installed by npm global) without shell: true. This causes binaryAvailable() to return ENOENT for codex and npm even when they are properly installed. Conditionally enables shell: true on win32 only.
Collaborator
|
Closing as duplicate of #13. Thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On Windows,
/codex:setupreports Codex CLI and npm as "not found" even when both are properly installed globally via npm.Root Cause
spawnSync("codex", ...)inprocess.mjscannot resolve.cmdwrappers on Windows withoutshell: true. Node.js on Windows requires either the explicit.cmdextension orshell: trueto find globally installed npm binaries. This is a well-documented Node.js behavior: https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windowsFix
Conditionally set
shell: process.platform === "win32"in therunCommandspawnSync options. This only enables shell resolution on Windows, avoiding any behavioral changes on macOS/Linux.Tested On