fix: add shell: true to spawn() in app-server for Windows#54
Closed
0xZOne wants to merge 1 commit intoopenai:mainfrom
Closed
fix: add shell: true to spawn() in app-server for Windows#540xZOne wants to merge 1 commit intoopenai:mainfrom
0xZOne wants to merge 1 commit intoopenai:mainfrom
Conversation
…lity On Windows, `codex` is installed as an npm `.cmd` shim. Node's `child_process.spawn()` cannot resolve `.cmd` files without `shell: true`, causing `ENOENT` when `SpawnedCodexAppServerClient` tries to start `codex app-server`. This is the same class of bug fixed in openai#13 for `spawnSync` in `process.mjs`, but the async `spawn()` call in `app-server.mjs` was missed.
Collaborator
|
Closing in favor of #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53
shell: process.platform === "win32"to thespawn()call inSpawnedCodexAppServerClient.initialize()so that Node can resolve thecodex.cmdshim on Windows.This is the same fix as #13 applied to
spawnSyncinprocess.mjs, but the asyncspawn()inapp-server.mjswas missed.Test plan
/codex:reviewsuccessfully starts the app-server and completes review after the fixprocess.platform === "win32")