chore(arg0): advisory-lock janitor for codex tmp paths#10039
chore(arg0): advisory-lock janitor for codex tmp paths#10039viyatb-oai merged 5 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2612b0d23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01db396790
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
I have some nits, but thanks for the thoughtful implementation!
viyatb-oai
force-pushed
the
codex/viyatb/arg0-path2-janitor-locks
branch
from
b909268 to
0489ee4
Compare
2 participants
Description
What changed
~/.codex/tmp/pathto~/.codex/tmp/path2Arg0PathEntryGuardto keep both theTempDirand an exclusive.lockfile alive for the process lifetimepath2and deletes only directories whose lock can be acquiredTests
cargo clippy -p codex-arg0cargo clippy -p codex-corecargo test -p codex-arg0cargo test -p codex-core