make codex better at git by pash-openai · Pull Request #10145 · openai/codex

pash-openai · 2026-01-29T08:51:39Z

adds basic git context to the session prefix so the model can anchor git actions and be a bit more version-aware. structured it in a multiroot-friendly shape even though we only have one root today

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 884de2d53b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/environment_context.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6057f2d49a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/environment_context.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30781cde87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/client.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c43909332

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/git_info.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 413d8435f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

pash-openai · 2026-01-30T22:42:52Z

codex-rs/core/src/git_info.rs

+) -> Option<std::process::Output> {
+    let mut command = Command::new("git");
+    command.args(args).current_dir(cwd);
+    command.kill_on_drop(true);


added kill_on_drop as a general safeguard - it doesn’t look like any callers rely on git continuing after the future is dropped

codex-rs/core/src/client.rs

aibrahim-oai · 2026-02-02T17:49:12Z

codex-rs/core/src/client.rs

            websocket_last_items: Vec::new(),
            transport_manager: self.state.transport_manager.clone(),
            turn_state: Arc::new(OnceLock::new()),
+            turn_metadata_header,


we can build the header on demand instead of storing it on the session

aibrahim-oai

Let's add an integration test to test the flow e2e

pash-openai · 2026-02-02T23:30:44Z

codex-rs/core/tests/responses_headers.rs

+        .unwrap_or_else(|_| cwd.to_path_buf())
+        .to_string_lossy()
+        .into_owned();
+    for _attempt in 0..10 {


this test is a bit involved (~200 lines) because i have to make multiple requests to verify that headers are eventually sent (because of the async prewarm)

codex-rs/core/src/client.rs

aibrahim-oai

LGTM, we have a lot of helper tests for integration tests that you can use to make the test shorter

pash-openai · 2026-02-03T00:57:13Z

/merge

pash-openai · 2026-02-03T01:00:43Z

LGTM, we have a lot of helper tests for integration tests that you can use to make the test shorter

For posterity, I tried using helper tests to make this test shorter, but in this case they obscured the runtime behavior and made the teest less reliable around the async prewarm timing. So I kept the test explicit on purpose so the behavior is clear and stable - i'll keep an eye on it for follow-ups

pash-openai changed the title ~~make codex better at git~~ feat: make codex better at git Jan 29, 2026

pash-openai changed the title ~~feat: make codex better at git~~ make codex better at git Jan 29, 2026

chatgpt-codex-connector bot reviewed Jan 29, 2026

View reviewed changes

codex-rs/core/src/environment_context.rs Outdated Show resolved Hide resolved

codex-rs/core/src/environment_context.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 29, 2026

View reviewed changes

codex-rs/core/src/environment_context.rs Outdated Show resolved Hide resolved

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from 9326378 to 05e0857 Compare January 29, 2026 09:26

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

codex-rs/core/src/client.rs Show resolved Hide resolved

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from 30781cd to b705c11 Compare January 30, 2026 02:19

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

codex-rs/core/src/git_info.rs Outdated Show resolved Hide resolved

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from 3c43909 to efbfa4b Compare January 30, 2026 16:40

chatgpt-codex-connector bot reviewed Jan 30, 2026

View reviewed changes

codex-rs/core/src/codex.rs Outdated Show resolved Hide resolved

pash-openai marked this pull request as draft January 30, 2026 17:42

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from 413d843 to 121f081 Compare January 30, 2026 19:31

etraut-openai added the oai PRs contributed by OpenAI employees label Jan 30, 2026

pash-openai force-pushed the codex/pash/session-workspace-git-context branch 2 times, most recently from a77b812 to 3a47181 Compare January 30, 2026 22:02

pash-openai marked this pull request as ready for review January 30, 2026 22:23

pash-openai commented Jan 30, 2026

View reviewed changes

aibrahim-oai reviewed Feb 2, 2026

View reviewed changes

codex-rs/core/src/client.rs Outdated Show resolved Hide resolved

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from b290663 to 2bc0f86 Compare February 2, 2026 06:01

aibrahim-oai reviewed Feb 2, 2026

View reviewed changes

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from 800cfc9 to c73c582 Compare February 2, 2026 19:02

pash-openai added 8 commits February 2, 2026 14:36

context in headers

e9d72bf

minor comment change

cd3c8f0

cleanup

24f198d

on-demand headers

1e29e09

cleanup

3e86d7f

cleanup

6f9867f

add e2e header test

d56aa8c

prewarm turn metadata

f1052e0

pash-openai force-pushed the codex/pash/session-workspace-git-context branch from da20ff0 to f1052e0 Compare February 2, 2026 22:36

pash-openai added 2 commits February 2, 2026 15:01

on-demand headers

e8bfe5a

cleanup

718ef24

pash-openai commented Feb 2, 2026

View reviewed changes

pash-openai added 3 commits February 2, 2026 15:34

removing line

01cace3

stale comment

c94e43b

test fix

1bc4f63

aibrahim-oai reviewed Feb 3, 2026

View reviewed changes

codex-rs/core/src/client.rs Outdated Show resolved Hide resolved

cleanup

8e6a677

aibrahim-oai approved these changes Feb 3, 2026

View reviewed changes

pash-openai added 2 commits February 2, 2026 16:36

test timeout

242f6a5

Merge branch 'main' into codex/pash/session-workspace-git-context

3807f36

pash-openai merged commit 019d89f into main Feb 3, 2026
32 checks passed

pash-openai deleted the codex/pash/session-workspace-git-context branch February 3, 2026 00:57

github-actions bot locked and limited conversation to collaborators Feb 3, 2026

Conversation

pash-openai commented Jan 29, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

pash-openai Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aibrahim-oai Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

aibrahim-oai left a comment

Choose a reason for hiding this comment

Uh oh!

pash-openai Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aibrahim-oai left a comment

Choose a reason for hiding this comment

Uh oh!

pash-openai commented Feb 3, 2026

Uh oh!

Uh oh!

pash-openai commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pash-openai Feb 2, 2026 •

edited

Loading