[feat] persist thread_dynamic_tools in db#10252
Merged
Conversation
b89a534 to
a45395a
Compare
fab93bf to
4758215
Compare
4758215 to
4176ec4
Compare
owenlin0
reviewed
Jan 30, 2026
jif-oai
approved these changes
Feb 2, 2026
Collaborator
jif-oai
left a comment
There was a problem hiding this comment.
I'm not sure the replace semantic makes sense as we don't want people to replace them after thread start but good for me
Collaborator
Author
will change the name to persist_dynamic_tools and gate it to only write tools when there's no dynamic tools for a thread |
33dc305 to
b7eea5e
Compare
b7eea5e to
57caba3
Compare
57caba3 to
44f9569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist thread_dynamic_tools in sqlite and read first from it. Fall back to rollout files if it's not found. Persist dynamic tools to both sqlite and rollout files.
Saw that new sessions get populated to db correctly & old sessions get backfilled correctly at startup: