fix(core) updated request_rule guidance#10379
Merged
dylan-hurd-oai merged 2 commits intomainfrom Feb 4, 2026
Merged
Conversation
dylan-hurd-oai
force-pushed
the
dh--banned-prefixes
branch
from
c71641b to
7a8341c
Compare
pakrym-oai
approved these changes
Feb 4, 2026
pakrym-oai
reviewed
Feb 4, 2026
| Some(prefixes) => { | ||
| format!( | ||
| "{APPROVAL_POLICY_ON_REQUEST_RULE}\nApproved command prefixes:\n{prefixes}" | ||
| "{APPROVAL_POLICY_ON_REQUEST_RULE}\n## Approved command prefixes\nThe following prefix rules have already been approved: {prefixes}" |
Collaborator
There was a problem hiding this comment.
no existing test? so sad..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update guidance for request_rule
Testing