Skip to content

fix: ensure status indicator present earlier in exec path#10700

Merged
sayan-oai merged 3 commits intomainfrom
dev/sayan/preamble-indicator-fix
Feb 5, 2026
Merged

fix: ensure status indicator present earlier in exec path#10700
sayan-oai merged 3 commits intomainfrom
dev/sayan/preamble-indicator-fix

Conversation

@sayan-oai
Copy link
Collaborator

@sayan-oai sayan-oai commented Feb 5, 2026

ensure status indicator present in all classifications of exec tool. fixes indicator disappearing after preambles, will look into using phase to avoid this class of error in a few hours.

commands parsed as unknown faced this issue

tested locally, added test for specific failure flow

@sayan-oai
Copy link
Collaborator Author

@codex review rhis

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshka-oai
Copy link
Collaborator

Compared with #10701: there is semantic overlap, but they cover different timing windows, so both are useful.

Together they address the "looks finished too early" UX across both phases.

I also suggest adding a visual snapshot test for the exec-begin path (in addition to the state/visibility assertion), so we verify the user-visible working affordance and guard against future rendering regressions.

@sayan-oai sayan-oai force-pushed the dev/sayan/preamble-indicator-fix branch from 1edfc71 to d0e99b8 Compare February 5, 2026 03:37
@sayan-oai sayan-oai enabled auto-merge (squash) February 5, 2026 03:40
@sayan-oai sayan-oai merged commit 4ed8d74 into main Feb 5, 2026
32 checks passed
@sayan-oai sayan-oai deleted the dev/sayan/preamble-indicator-fix branch February 5, 2026 03:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants